Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low level functionality for listing interpreters associated with a channel #52

Closed
nanjekyejoannah opened this issue Sep 13, 2019 · 6 comments
Labels
complexity: low easy to figure out size: small requires few changes type: enhancement X [stdlib API] exposing C impl in Python code

Comments

@nanjekyejoannah
Copy link
Collaborator

One of the attributes for class RecvChannel(id) and class SendChannel(id) is interpreters but currently there is no low-level functionality to associate interpreters with a channel.

@ericsnowcurrently ericsnowcurrently added complexity: low easy to figure out size: small requires few changes type: enhancement X [stdlib API] exposing C impl in Python code labels Sep 13, 2019
@LewisGaul
Copy link

Hi there, I'm a new contributor interested in getting involved with this project and was wondering if this issue might be suitable. Could anyone provide any pointers for where to start with implementing this?

@nanjekyejoannah
Copy link
Collaborator Author

nanjekyejoannah commented Oct 27, 2019

@LewisGaul Thanks for offerring to help. This week, I will resume my work on this: nanjekyejoannah/cpython#1 and I really needed this low level feature. Am happy to hear from you especially this week but no pressure.

The low level subinterpreters functionality are implemented in Modules/_xxsubinterpretersmodule.c . The file has similar functions. You can take a look for some leads. I hope this helps.

Feel free ask more questions If you have any.

@LewisGaul
Copy link

@LewisGaul Thanks for offerring to help. This week, I will resume my work on this: nanjekyejoannah/cpython#1 and I really needed this low level module. Am happy to hear from you especially this week but no pressure.

The low level subinterpreters functionality are implemented in Modules/_xxsubinterpretersmodule.c . The file has similar functions. You can take a look for some leads. I hope this helps.

Feel free ask more questions If you have any.

Thanks for the pointers Joannah, I took a look at your interpreters module implementation - it's cool to have a runnable proof-of-concept :)

I'll take a further look into this when I have time, hopefully this week.

@LewisGaul
Copy link

Would anyone be able to take a quick look at the PR I have open at LewisGaul/cpython#3 to check I'm heading in the right direction before spending time polishing it? Please ask if anything isn't clear :)

@ericsnowcurrently
Copy link
Owner

Thanks for working on this, @LewisGaul. I'm taking a look today.

miss-islington pushed a commit to python/cpython that referenced this issue Apr 29, 2020
@ericsnowcurrently
Copy link
Owner

The PR has been merged! Thanks again, @LewisGaul!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: low easy to figure out size: small requires few changes type: enhancement X [stdlib API] exposing C impl in Python code
Projects
None yet
Development

No branches or pull requests

3 participants