Rework the NavigationHeader #21
Conversation
|
Sorry about the delay on this Satyajit! I'll merge it tonight |
|
Cool. Thanks :) |
|
I landed #19 tonight, so it caused some thrash in the code I've done most of the merging on this branch here: https://github.com/ericvicenti/navigation-rfc/tree/navheader But there is still a bridge number error that shows up, as well as some small formatting issues. Would you mind taking a look? |
|
@ericvicenti Hey. Will do ASAP. Thanks :) |
|
Will be great if you can comment on the formatting issues :) |
|
Merged master to my branch. |
|
BTW I see this error on master (after running AsyncStorage.clear(), otherwise it wasn't displaying anything). This only happens on iOS, not Android.
|
|
I only noticed that issue after I patched in your header changes |
|
@ericvicenti Hey. Seems that it only happens if Chrome debugger is connected. (Both in master and my branch). This not specifically related to my branch. Here is a screencast confirming that it happens on master - https://www.youtube.com/watch?v=KdSdBDgXFIE Sorry, I would've taken a hit at this, but I've no idea where it's coming from and why :( |
Rework the NavigationHeader
|
Ah, in that case I'll merge your PR now! The redbox seems to be caused by the transform translateX in the NavigationCard.. hrmmm. It could be a bug in Animated, but more likely something going wrong with chrome debugging. |
|
Awesome! 🎉 |
|
I'm also seeing the error on the master branch of RN with old Navigator code. |
Summary: A new API to unify internal navigation. Also addresses a highly-rated community 'pain': https://productpains.com/post/react-native/better-navigator-api-and-docs/ Offers the following improvements: - Redux-style navigation logic is easy to reason about - Navigation state can be easily saved and restored through refreshes - Declarative navigation views can be implemented in native or JS - Animations and gestures are isolated and now use the Animated library public Reviewed By: hedgerwang Differential Revision: D2798048 fb-gh-sync-id: 88027ef9ead8a80afa38354252bc377455cc6dbb
Summary:Add ability to specify custom left, right components, and title component. Style the `NavigationBar` according to the Platform. Refer ericvicenti/navigation-rfc#21 cc ericvicenti Closes #5971 Differential Revision: D3080601 Pulled By: ericvicenti fb-gh-sync-id: 7b921cd36b4c2ec1edf6f52629f1f9890d272dfd shipit-source-id: 7b921cd36b4c2ec1edf6f52629f1f9890d272dfd
Make
<NavigationHeader />work on both iOS and Android, and make it more customizable. Refer #20iOS:
Android: