Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action to make sure webring builds #140

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

sivakusayan
Copy link
Contributor

@sivakusayan sivakusayan commented Sep 21, 2023

This should fix #124.

As an aside, I had to bump the netlify-cli package to get around an EBADPLATFORM issue that would occur when installing the dependencies with npm ci. I hope this is OK, but let me know if it's not and I can try figuring another way around it.

How I tested

I used the act repo to test this action locally, but you can test this in any way you like.

  1. Introduce some error in the data/members folder (I just deleted a comma from a random JSON file).
  2. Verify that running the GitHub action fails.
  3. Remove the error introduced in step 1.
  4. Verify that running the GitHub action succeeds.

@ericwbailey
Copy link
Owner

I think this should be great! Thank you for taking the time to make and test this, it's really appreciated.

@ericwbailey ericwbailey merged commit c8c4604 into ericwbailey:main Sep 24, 2023
1 check passed
@sivakusayan sivakusayan deleted the addCI branch September 26, 2023 12:33
@ericwbailey
Copy link
Owner

Just wanted to say thank you again for adding this functionality. I've added a few new members in and it works like a charm 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider checking for build errors as a pre-commit check
2 participants