-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add erigon_getBalanceChangesInBlock RPC endpoint #4609
Add erigon_getBalanceChangesInBlock RPC endpoint #4609
Conversation
if err != nil { | ||
t.Errorf("calling GetBalanceChangesInBlock resulted in an error: %v", err) | ||
} | ||
PrintChangedBalances(balances) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to put couple of asserts here?
@tsutsu please also update the REAMDE for rpcdaemon and include the new API method |
Should this be in the |
I agree; this isn't a standardized endpoint (and in fact wouldn't be supportable in other clients due to only being practical with a ChangeSet-like index) so shouldn't be under |
@tsutsu let's add real test asserts and move it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(1) add assets to this tes
(2) move to erigon_
namespace
Here are some assertions: 25be3d6 |
I will add line to cmd/rpcdaemon/readme.md |
@mandrigin let's merge? |
Done! |
No description provided.