dvovk/headers info #9748
Merged
dvovk/headers info #9748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dvovk
commented
Mar 18, 2024
dvovk
commented
- collecting info for "Headers" stage
dvovk
requested review from
mh0lt,
shohamc1 and
AskAlexSharov
and removed request for
mh0lt and
shohamc1
AskAlexSharov
requested changes
Mar 28, 2024
erigon-lib/diagnostics/headers.go
Outdated
| ctx, ch, cancel := Context[HeaderCanonicalMarkerUpdate](context.Background(), 1) | ||
| defer cancel() | ||
|
|
||
| rootCtx, _ := common.RootContext() |
There was a problem hiding this comment.
-
common.RootContext()- it's not global variable access - it's constructor. and better don't have more than 1 root context.
please pass existing root context toDiagnosticClientconstructor. save it as field and use here.
(feel free to rename RootContext to NewRootContext) -
cancel 1 context based on another one - it's anti-pattern:
case <-rootCtx.Done():
cancel()
better establish child-parent relationship between contexts: Context[HeaderCanonicalMarkerUpdate](context.Background() -> Context[HeaderCanonicalMarkerUpdate](rootCtx
|
AskAlexSharov
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.