Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Adding skeleton code for the daemon and a testing client #2

Closed
wants to merge 37 commits into from

Conversation

tjayrush
Copy link
Contributor

@tjayrush tjayrush commented Nov 22, 2020

Closes #1.

This is ready to merge. I left the kv.proto work as it did earlier, but for the non-kv protos, they are built into the build folder.

@tjayrush tjayrush changed the title [WIP] Adding very early code for the daemon to the build Adding very early code for the daemon to the build Nov 23, 2020
@tjayrush tjayrush changed the title Adding very early code for the daemon to the build Adding skeleton code for the daemon and a testing client Nov 23, 2020
@canepat
Copy link
Member

canepat commented Nov 24, 2020

@tjayrush I've tried to build this branch locally but fails with the same error reported by CI job linux-clang-coverage:

CMake Error at silkrpc/CMakeLists.txt:94 (file):
  file COPY cannot find "/home/builder/build/eth.pb.cc": No such file or
  directory.

@canepat
Copy link
Member

canepat commented Nov 24, 2020

Moreover I would like to discuss where we should place things in the repo (maybe we could write a guideline after we reach an agreement) because IMHO notes folder should be placed outside silkrpc subtree.

@tjayrush
Copy link
Contributor Author

@tjayrush I've tried to build this branch locally but fails with the same error reported by CI job linux-clang-coverage:

CMake Error at silkrpc/CMakeLists.txt:94 (file):
  file COPY cannot find "/home/builder/build/eth.pb.cc": No such file or
  directory.

I think I should use a custom_command here. file(COPY (I guess) is a cmake time command (it runs during the cmake). After make clean, the files don't exists and they do not exist until protoc creates them (which happens during make), so of course cmake can't find them.

I commented this out for now. We can discuss tomorrow.

@tjayrush
Copy link
Contributor Author

Moreover I would like to discuss where we should place things in the repo (maybe we could write a guideline after we reach an agreement) because IMHO notes folder should be placed outside silkrpc subtree.

I'm totally open to re-arranging the files in any way that works. In fact, notes is really only for my use, so maybe we can put it in the .gitignore or something.

Again, we can discuss tomorrow.

@tjayrush tjayrush closed this Nov 25, 2020
@tjayrush tjayrush deleted the 001-update-build branch November 25, 2020 00:26
lupin012 added a commit that referenced this pull request Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants