-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for access tokens #185
Conversation
@erikbra We look to have some CI issues atm, I'll try and have a look at those tonight for you. |
I think I had that same issue locally (before my change) but I figured I messed up something so I just commented it out to get it to build but didn't commit it. |
I tested that unit tests pass and my change also still works after merging main to my branch. |
Yep all looks good on this side. I was just giving Erik another day or two to respond (as it is primarily his codebase) |
Hi, guys. Terribly sorry for going "missing" on you here. There are a lot of other things going on ATM, so I haven't had much (any) time to follow up here. I really, really wish the SqlConnection could support specifying the access token in the connection string, but, apparently it doesn't. It was definitely an oversight on my part originally. Thanks a lot for your contribution, @kimjamia ! And thanks for following up, @wokket ! Merging this :) |
Add support for login in with an access token to SQL Server / Azure SQL Database.
Required for #115 as tokens can't be passed via the connection string.