Partial revamp of ranges/intervals #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thin a bigger one
… div/rem operators
…ealing with fixed offsets
…ming of similar conversion methods
* Move system time zone off of the clock * Fix missing Darwin import
* Validate minimumDAysInFirstWeek in WeekSettings constructor * Add week number and year properties
* Update docs to reflect addition of week number support * Fix casing * More tweaks
* Enable construction of dates from week date representation * Fix validation on week date construction * Fix compile error
…provements # Conflicts: # core/src/commonMain/kotlin/io/islandtime/ranges/ZonedDateTimeInterval.kt
…110) * Add methods to access week-related properties directly using Locale * Fix Darwin build
* Move some Date properties to generated extension functions * Update generated file to reflect changes from merge
* Re-work the clock implementation on JVM * Re-work new clock implementation to handle Darwin * Minor clean up
* Build with Kotlin 1.4-M2 * Remove workarounds that should no longer be needed * Update to Kotlin 1.4-M3 * Revert removal of IDEA hack * Enable MPP compatibility mode * Prepare for 0.2.3-1.4-M3 release * Restore AtomicFU runtime dependency * Work around Kotlin 1.4 compiler error * Prepare for 0.2.4-1.4-M3 release * Prepare for next release * Bump Kotlin to 1.4.0-rc * Prepare for 0.2.4-1.4-rc release * Prepare for next release * Remove "-1.4-rc" from SNAPSHOT version
…provements # Conflicts: # buildSrc/build.gradle.kts # buildSrc/src/main/kotlin/Dependencies.kt # buildSrc/src/main/kotlin/android-library.gradle.kts # buildSrc/src/main/kotlin/multiplatform-library.gradle.kts # buildSrc/src/main/kotlin/published-library.gradle.kts # core/build.gradle.kts # core/gradle.properties # core/packages.md # core/src/commonMain/generated/io/islandtime/measures/_Centuries.kt # core/src/commonMain/generated/io/islandtime/measures/_Days.kt # core/src/commonMain/generated/io/islandtime/measures/_Decades.kt # core/src/commonMain/generated/io/islandtime/measures/_Hours.kt # core/src/commonMain/generated/io/islandtime/measures/_Microseconds.kt # core/src/commonMain/generated/io/islandtime/measures/_Milliseconds.kt # core/src/commonMain/generated/io/islandtime/measures/_Minutes.kt # core/src/commonMain/generated/io/islandtime/measures/_Months.kt # core/src/commonMain/generated/io/islandtime/measures/_Nanoseconds.kt # core/src/commonMain/generated/io/islandtime/measures/_Seconds.kt # core/src/commonMain/generated/io/islandtime/measures/_Weeks.kt # core/src/commonMain/generated/io/islandtime/measures/_Years.kt # core/src/commonMain/kotlin/io/islandtime/Conversions.kt # core/src/commonMain/kotlin/io/islandtime/Date.kt # core/src/commonMain/kotlin/io/islandtime/DateTime.kt # core/src/commonMain/kotlin/io/islandtime/DayOfWeek.kt # core/src/commonMain/kotlin/io/islandtime/Instant.kt # core/src/commonMain/kotlin/io/islandtime/IslandTime.kt # core/src/commonMain/kotlin/io/islandtime/OffsetDateTime.kt # core/src/commonMain/kotlin/io/islandtime/OffsetTime.kt # core/src/commonMain/kotlin/io/islandtime/Time.kt # core/src/commonMain/kotlin/io/islandtime/TimeZone.kt # core/src/commonMain/kotlin/io/islandtime/UtcOffset.kt # core/src/commonMain/kotlin/io/islandtime/WeekDate.kt # core/src/commonMain/kotlin/io/islandtime/Year.kt # core/src/commonMain/kotlin/io/islandtime/YearMonth.kt # core/src/commonMain/kotlin/io/islandtime/ZonedDateTime.kt # core/src/commonMain/kotlin/io/islandtime/base/DateTimeField.kt # core/src/commonMain/kotlin/io/islandtime/base/TimePoint.kt # core/src/commonMain/kotlin/io/islandtime/calendar/WeekSettings.kt # core/src/commonMain/kotlin/io/islandtime/clock/Clock.kt # core/src/commonMain/kotlin/io/islandtime/clock/FixedClock.kt # core/src/commonMain/kotlin/io/islandtime/clock/Now.kt # core/src/commonMain/kotlin/io/islandtime/clock/SystemClock.kt # core/src/commonMain/kotlin/io/islandtime/clock/internal/NowImpl.kt # core/src/commonMain/kotlin/io/islandtime/clock/internal/SystemClockImpl.kt # core/src/commonMain/kotlin/io/islandtime/format/DateTimeTextProvider.kt # core/src/commonMain/kotlin/io/islandtime/format/NumberStyle.kt # core/src/commonMain/kotlin/io/islandtime/format/TextStyle.kt # core/src/commonMain/kotlin/io/islandtime/format/TimeZoneTextProvider.kt # core/src/commonMain/kotlin/io/islandtime/internal/Deprecation.kt # core/src/commonMain/kotlin/io/islandtime/internal/Instants.kt # core/src/commonMain/kotlin/io/islandtime/internal/Math.kt # core/src/commonMain/kotlin/io/islandtime/internal/PlatformImpl.kt # core/src/commonMain/kotlin/io/islandtime/internal/WeekNumbers.kt # core/src/commonMain/kotlin/io/islandtime/locale/Locale.kt # core/src/commonMain/kotlin/io/islandtime/measures/Duration.kt # core/src/commonMain/kotlin/io/islandtime/measures/Period.kt # core/src/commonMain/kotlin/io/islandtime/measures/TimeUnit.kt # core/src/commonMain/kotlin/io/islandtime/measures/internal/Extensions.kt # core/src/commonMain/kotlin/io/islandtime/operators/PreviousNext.kt # core/src/commonMain/kotlin/io/islandtime/operators/Round.kt # core/src/commonMain/kotlin/io/islandtime/operators/RoundDown.kt # core/src/commonMain/kotlin/io/islandtime/operators/RoundUp.kt # core/src/commonMain/kotlin/io/islandtime/operators/StartEnd.kt # core/src/commonMain/kotlin/io/islandtime/operators/Truncation.kt # core/src/commonMain/kotlin/io/islandtime/operators/Week.kt # core/src/commonMain/kotlin/io/islandtime/operators/internal/CopyIfChanged.kt # core/src/commonMain/kotlin/io/islandtime/operators/internal/RoundImpl.kt # core/src/commonMain/kotlin/io/islandtime/parser/DateTimeFieldBuilders.kt # core/src/commonMain/kotlin/io/islandtime/parser/DateTimeParseException.kt # core/src/commonMain/kotlin/io/islandtime/parser/DateTimeParseResult.kt # core/src/commonMain/kotlin/io/islandtime/parser/DateTimeParser.kt # core/src/commonMain/kotlin/io/islandtime/parser/DateTimeParserDsl.kt # core/src/commonMain/kotlin/io/islandtime/parser/DateTimeParserSettings.kt # core/src/commonMain/kotlin/io/islandtime/parser/DateTimeParsers.kt # core/src/commonMain/kotlin/io/islandtime/parser/GroupedDateTimeParser.kt # core/src/commonMain/kotlin/io/islandtime/parser/internal/DateTimeParseContext.kt # core/src/commonMain/kotlin/io/islandtime/parser/internal/DateTimeParserBuilder.kt # core/src/commonMain/kotlin/io/islandtime/parser/internal/GroupedDateTimeParserBuilder.kt # core/src/commonMain/kotlin/io/islandtime/parser/internal/ParserBuilders.kt # core/src/commonMain/kotlin/io/islandtime/parser/internal/Parsers.kt # core/src/commonMain/kotlin/io/islandtime/ranges/Builders.kt # core/src/commonMain/kotlin/io/islandtime/ranges/Conversions.kt # core/src/commonMain/kotlin/io/islandtime/ranges/DateIterators.kt # core/src/commonMain/kotlin/io/islandtime/ranges/DateProgressions.kt # core/src/commonMain/kotlin/io/islandtime/ranges/DateRange.kt # core/src/commonMain/kotlin/io/islandtime/ranges/DateTimeInterval.kt # core/src/commonMain/kotlin/io/islandtime/ranges/InstantInterval.kt # core/src/commonMain/kotlin/io/islandtime/ranges/OffsetDateTimeInterval.kt # core/src/commonMain/kotlin/io/islandtime/ranges/TimePointInterval.kt # core/src/commonMain/kotlin/io/islandtime/ranges/TimePointIterators.kt # core/src/commonMain/kotlin/io/islandtime/ranges/TimePointProgressions.kt # core/src/commonMain/kotlin/io/islandtime/ranges/ZonedDateTimeInterval.kt # core/src/commonMain/kotlin/io/islandtime/ranges/internal/Common.kt # core/src/commonMain/kotlin/io/islandtime/zone/TimeZoneRules.kt # core/src/commonTest/kotlin/io/islandtime/ConversionsTest.kt # core/src/commonTest/kotlin/io/islandtime/DatePropertiesTest.kt # core/src/commonTest/kotlin/io/islandtime/DateTest.kt # core/src/commonTest/kotlin/io/islandtime/DateTimeTest.kt # core/src/commonTest/kotlin/io/islandtime/DayOfWeekTest.kt # core/src/commonTest/kotlin/io/islandtime/InstantTest.kt # core/src/commonTest/kotlin/io/islandtime/IslandTimeTest.kt # core/src/commonTest/kotlin/io/islandtime/OffsetDateTimeTest.kt # core/src/commonTest/kotlin/io/islandtime/TimeTest.kt # core/src/commonTest/kotlin/io/islandtime/TimeZoneTest.kt # core/src/commonTest/kotlin/io/islandtime/WeekDateTest.kt # core/src/commonTest/kotlin/io/islandtime/YearTest.kt # core/src/commonTest/kotlin/io/islandtime/ZonedDateTimeTest.kt # core/src/commonTest/kotlin/io/islandtime/calendar/WeekSettingsTest.kt # core/src/commonTest/kotlin/io/islandtime/clock/ClockTest.kt # core/src/commonTest/kotlin/io/islandtime/clock/NowTest.kt # core/src/commonTest/kotlin/io/islandtime/format/DateTimeTextProviderTest.kt # core/src/commonTest/kotlin/io/islandtime/format/NumberStyleTest.kt # core/src/commonTest/kotlin/io/islandtime/format/TextStyleTest.kt # core/src/commonTest/kotlin/io/islandtime/format/TimeZoneTextProviderTest.kt # core/src/commonTest/kotlin/io/islandtime/internal/MathTest.kt # core/src/commonTest/kotlin/io/islandtime/measures/DaysTest.kt # core/src/commonTest/kotlin/io/islandtime/measures/DurationTest.kt # core/src/commonTest/kotlin/io/islandtime/measures/NanosecondsTest.kt # core/src/commonTest/kotlin/io/islandtime/measures/PeriodTest.kt # core/src/commonTest/kotlin/io/islandtime/measures/YearsTest.kt # core/src/commonTest/kotlin/io/islandtime/operators/PreviousNextTest.kt # core/src/commonTest/kotlin/io/islandtime/operators/RoundDownTest.kt # core/src/commonTest/kotlin/io/islandtime/operators/RoundTest.kt # core/src/commonTest/kotlin/io/islandtime/operators/RoundUpTest.kt # core/src/commonTest/kotlin/io/islandtime/operators/StartEndTest.kt # core/src/commonTest/kotlin/io/islandtime/operators/TruncationTest.kt # core/src/commonTest/kotlin/io/islandtime/parser/AnyOfParserTest.kt # core/src/commonTest/kotlin/io/islandtime/parser/CaseSensitivityTest.kt # core/src/commonTest/kotlin/io/islandtime/parser/DateTimeParserTest.kt # core/src/commonTest/kotlin/io/islandtime/parser/DecimalNumberParserTest.kt # core/src/commonTest/kotlin/io/islandtime/parser/GroupedDateTimeParserTest.kt # core/src/commonTest/kotlin/io/islandtime/parser/LocalizedTextParserTest.kt # core/src/commonTest/kotlin/io/islandtime/parser/OptionalParserTest.kt # core/src/commonTest/kotlin/io/islandtime/parser/StringParserTest.kt # core/src/commonTest/kotlin/io/islandtime/parser/WholeNumberParserTest.kt # core/src/commonTest/kotlin/io/islandtime/parser/internal/ParsersTest.kt # core/src/commonTest/kotlin/io/islandtime/ranges/BuildersTest.kt # core/src/commonTest/kotlin/io/islandtime/ranges/ConversionsTest.kt # core/src/commonTest/kotlin/io/islandtime/ranges/DateRangeTest.kt # core/src/commonTest/kotlin/io/islandtime/ranges/DateTimeIntervalTest.kt # core/src/commonTest/kotlin/io/islandtime/ranges/InstantIntervalTest.kt # core/src/commonTest/kotlin/io/islandtime/ranges/InstantProgressionTest.kt # core/src/commonTest/kotlin/io/islandtime/ranges/OffsetDateTimeIntervalTest.kt # core/src/commonTest/kotlin/io/islandtime/ranges/ZonedDateTimeIntervalTest.kt # core/src/commonTest/kotlin/io/islandtime/test/AbstractIslandTimeTest.kt # core/src/commonTest/kotlin/io/islandtime/test/TestData.kt # core/src/commonTest/kotlin/io/islandtime/zone/PlatformTimeZoneRulesTest.kt # core/src/darwinMain/kotlin/io/islandtime/PlatformInstant.kt # core/src/darwinMain/kotlin/io/islandtime/calendar/WeekSettings.kt # core/src/darwinMain/kotlin/io/islandtime/clock/internal/NowImpl.kt # core/src/darwinMain/kotlin/io/islandtime/clock/internal/SystemClockImpl.kt # core/src/darwinMain/kotlin/io/islandtime/darwin/Conversions.kt # core/src/darwinMain/kotlin/io/islandtime/format/DateTimeTextProvider.kt # core/src/darwinMain/kotlin/io/islandtime/format/NumberStyle.kt # core/src/darwinMain/kotlin/io/islandtime/format/TimeZoneTextProvider.kt # core/src/darwinMain/kotlin/io/islandtime/internal/Concurrency.kt # core/src/darwinMain/kotlin/io/islandtime/internal/Math.kt # core/src/darwinMain/kotlin/io/islandtime/internal/PlatformImpl.kt # core/src/darwinMain/kotlin/io/islandtime/locale/Locale.kt # core/src/darwinMain/kotlin/io/islandtime/zone/TimeZoneRules.kt # core/src/darwinTest/kotlin/io/islandtime/darwin/ConversionsTest.kt # core/src/darwinTest/kotlin/io/islandtime/format/DarwinNumberFormatTest.kt # core/src/darwinTest/kotlin/io/islandtime/format/DarwinTimeZoneTextProviderTest.kt # core/src/jvmMain/kotlin/io/islandtime/PlatformInstant.kt # core/src/jvmMain/kotlin/io/islandtime/calendar/WeekSettings.kt # core/src/jvmMain/kotlin/io/islandtime/clock/internal/Conversions.kt # core/src/jvmMain/kotlin/io/islandtime/clock/internal/NowImpl.kt # core/src/jvmMain/kotlin/io/islandtime/clock/internal/SystemClockImpl.kt # core/src/jvmMain/kotlin/io/islandtime/clock/jvm/Now.kt # core/src/jvmMain/kotlin/io/islandtime/format/DateTimeTextProvider.kt # core/src/jvmMain/kotlin/io/islandtime/format/NumberStyle.kt # core/src/jvmMain/kotlin/io/islandtime/format/TimeZoneTextProvider.kt # core/src/jvmMain/kotlin/io/islandtime/internal/Math.kt # core/src/jvmMain/kotlin/io/islandtime/internal/PlatformImpl.kt # core/src/jvmMain/kotlin/io/islandtime/jvm/Conversions.kt # core/src/jvmMain/kotlin/io/islandtime/locale/Locale.kt # core/src/jvmMain/kotlin/io/islandtime/zone/TimeZoneRules.kt # core/src/jvmMain/resources/META-INF/proguard/islandtime.pro # core/src/jvmTest/kotlin/io/islandtime/calendar/JvmWeekSettingsTest.kt # core/src/jvmTest/kotlin/io/islandtime/clock/jvm/JvmNowTest.kt # core/src/jvmTest/kotlin/io/islandtime/format/JvmTimeZoneTextProviderTest.kt # core/src/jvmTest/kotlin/io/islandtime/jvm/ConversionsTest.kt # core/src/jvmTest/kotlin/io/islandtime/jvm/DateTimeComparisonTest.kt # docs/advanced/custom-providers.md # docs/basics/dates-and-times.md # docs/basics/durations.md # docs/basics/formatting.md # docs/basics/general-design.md # docs/basics/interop.md # docs/basics/intervals.md # docs/basics/parsing.md # docs/extensions/parcelize.md # docs/getting-started.md # docs/index.md # extensions/parcelize/build.gradle.kts # extensions/parcelize/gradle.properties # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/DateTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/DateTimeTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/InstantTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/OffsetDateTimeTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/OffsetTimeTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/TimeTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/TimeZoneTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/YearMonthTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/ZonedDateTimeTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/measures/DurationTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/measures/PeriodTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/ranges/DateRangeTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/ranges/DateTimeIntervalTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/ranges/InstantIntervalTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/ranges/OffsetDateTimeIntervalTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/ranges/ZonedDateTimeIntervalTest.kt # extensions/parcelize/src/androidTest/kotlin/io/islandtime/extensions/parcelize/test/TestParcelable.kt # extensions/parcelize/src/main/AndroidManifest.xml # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/Date.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/DateTime.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/Instant.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/OffsetDateTime.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/OffsetTime.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/Time.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/TimeZone.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/YearMonth.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/ZonedDateTime.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/measures/Duration.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/measures/Period.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/ranges/DateRange.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/ranges/DateTimeInterval.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/ranges/InstantInterval.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/ranges/OffsetDateTimeInterval.kt # extensions/parcelize/src/main/kotlin/io/islandtime/extensions/parcelize/ranges/ZonedDateTimeInterval.kt # extensions/serialization/build.gradle.kts # extensions/serialization/gradle.properties # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/Date.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/DateTime.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/Instant.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/OffsetDateTime.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/OffsetTime.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/Time.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/TimeZone.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/YearMonth.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/ZonedDateTime.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/measures/Duration.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/measures/Period.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/ranges/DateRange.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/ranges/DateTimeInterval.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/ranges/InstantInterval.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/ranges/OffsetDateTimeInterval.kt # extensions/serialization/src/commonMain/kotlin/io/islandtime/extensions/serialization/ranges/ZonedDateTimeInterval.kt # extensions/serialization/src/commonTest/kotlin/io/islandtime/extensions/serialization/SerializerTest.kt # gradle.properties # gradle/wrapper/gradle-wrapper.properties # mkdocs.yml # settings.gradle.kts # tools/code-generator/build.gradle.kts # tools/code-generator/src/main/kotlin/io/islandtime/codegen/Generator.kt # tools/code-generator/src/main/kotlin/io/islandtime/codegen/Main.kt # tools/code-generator/src/main/kotlin/io/islandtime/codegen/descriptions/DateTimeDescription.kt # tools/code-generator/src/main/kotlin/io/islandtime/codegen/descriptions/IntervalDescription.kt # tools/code-generator/src/main/kotlin/io/islandtime/codegen/descriptions/TemporalUnitDescription.kt # tools/code-generator/src/main/kotlin/io/islandtime/codegen/dsl/CodeWriterDsl.kt # tools/code-generator/src/main/kotlin/io/islandtime/codegen/dsl/KotlinPoetExtensions.kt # tools/code-generator/src/main/kotlin/io/islandtime/codegen/generators/ConstantsGenerator.kt # tools/code-generator/src/main/kotlin/io/islandtime/codegen/generators/DateConversionsGenerator.kt # tools/code-generator/src/main/kotlin/io/islandtime/codegen/generators/DatePropertiesGenerator.kt # tools/code-generator/src/main/kotlin/io/islandtime/codegen/generators/TemporalUnitGenerator.kt # tools/code-generator/src/main/kotlin/io/islandtime/codegen/util/Extensions.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revamps the ranges/intervals a bit and improves code reuse. It's a breaking change, but not likely to have a big impact. At some point, will need to explore creating separate classes for each interval state to avoid the use of sentinels -- that may make things less clumsy too.