Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot parse strings with certain allowed characters #42

Closed
michaelficarra opened this issue Aug 9, 2015 · 1 comment
Closed

cannot parse strings with certain allowed characters #42

michaelficarra opened this issue Aug 9, 2015 · 1 comment

Comments

@michaelficarra
Copy link

I ran into this issue using a literal "escape" character (code point 27), which should be allowed within a string. The workaround for now is to use the \x1B escape sequence.

Ref. purescript/purescript#1265
erikd added a commit that referenced this issue Aug 10, 2015
@erikd
Lexer: Improve handling of character literals in strings
68867fb 
The reported issue was about '\x1b' (escape) embedded in a string
but it turned out to be a problem with all characters with an ordinal
value of < 0x20.

Closes: #42
erikd added a commit that referenced this issue Aug 10, 2015
@erikd
Lexer: Improve handling of character literals in strings
ec3d63c 
The reported issue was about '\x1b' (escape) embedded in a string
but it turned out to be a problem with all characters with an ordinal
value of < 0x20.

Closes: #42
@erikd
Copy link
Owner

erikd commented Aug 10, 2015

Fixed in both the master and new-ast branches in the above commits. The tests in the new-ast branch are much more extensive that the ones in the master branch.

@erikd erikd closed this as completed Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelficarra @erikd