Lazy-load io/console to avoid activating the gem unecessarily #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping on getting this reviewed? Thanks! |
|
Hey, have you found it to be performance issue? I'm curious to see whether hiding file dependency in the bowels of codebase is good enough tradeoff? |
|
The main reason to lazy loading it is that it is being extracted to a gem in Ruby 2.4+ and it may not be present in a ruby installation. It also is only necessary if the ruby installation doesn't have readline. This change does make sense. Thanks. |
|
Its not a performance issue, but rather an issue for bundler & other gems -- if io-console is eagerly loaded, then the user cannot control what version is used |
|
I'm asking cuz I'm in a similar boat relying on 'io-console' and in particular in changing echo mode. I guess I'm looking for a robust solution. For example, what will happen if you're running on Ruby 2.4 and |
|
Yeah, that is what would happen today. We can improve it though with a fallback. |
Iristyle
added a commit
to Iristyle/puppet
that referenced
this pull request
May 10, 2017
- On Fedora 25, Bundler will outright crash as it has a hard dependency on io/console by way of the Thor CLI library. Bundler 1.14-6 vendors Thor 0.19.1 https://github.com/bundler/bundler/blob/v1.14.6/lib/bundler/vendor/thor/lib/thor/version.rb https://github.com/erikhuda/thor/blob/v0.19.1/lib/thor/shell/basic.rb#L2 The hard dependency has been removed in an as of yet unshipped version of Thor via rails/thor#539 meaning that at some point it will not be necessary to have io/console installed for Bundler. For now, it remains a hard dependency, without which calling Bundler will fail with an error like: /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- io/console (LoadError) from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell/basic.rb:2:in `<top (required)>' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell/color.rb:1:in `<top (required)>' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell.rb:17:in `shell' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/ui/shell.rb:15:in `initialize' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:13:in `new' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:13:in `rescue in start' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:17:in `start' from /usr/local/share/gems/gems/bundler-1.14.6/exe/bundle:32:in `block in <top (required)>' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors' from /usr/local/share/gems/gems/bundler-1.14.6/exe/bundle:24:in `<top (required)>' from /usr/local/bin/bundle:23:in `load' from /usr/local/bin/bundle:23:in `<main>'
Iristyle
added a commit
to Iristyle/puppet
that referenced
this pull request
May 10, 2017
- On Fedora 25, Bundler will outright crash as it has a hard dependency on io/console by way of the Thor CLI library. Bundler 1.14-6 vendors Thor 0.19.1 https://github.com/bundler/bundler/blob/v1.14.6/lib/bundler/vendor/thor/lib/thor/version.rb https://github.com/erikhuda/thor/blob/v0.19.1/lib/thor/shell/basic.rb#L2 The hard dependency has been removed in an as of yet unshipped version of Thor via rails/thor#539 meaning that at some point it will not be necessary to have io/console installed for Bundler. For now, it remains a hard dependency, without which calling Bundler will fail with an error like: /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- io/console (LoadError) from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell/basic.rb:2:in `<top (required)>' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell/color.rb:1:in `<top (required)>' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell.rb:17:in `shell' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/ui/shell.rb:15:in `initialize' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:13:in `new' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:13:in `rescue in start' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:17:in `start' from /usr/local/share/gems/gems/bundler-1.14.6/exe/bundle:32:in `block in <top (required)>' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors' from /usr/local/share/gems/gems/bundler-1.14.6/exe/bundle:24:in `<top (required)>' from /usr/local/bin/bundle:23:in `load' from /usr/local/bin/bundle:23:in `<main>'
Iristyle
added a commit
to Iristyle/puppet
that referenced
this pull request
May 10, 2017
- On Fedora 25, Bundler will outright crash as it has a hard dependency on io/console by way of the Thor CLI library. Bundler 1.14-6 vendors Thor 0.19.1 https://github.com/bundler/bundler/blob/v1.14.6/lib/bundler/vendor/thor/lib/thor/version.rb https://github.com/erikhuda/thor/blob/v0.19.1/lib/thor/shell/basic.rb#L2 The hard dependency has been removed in an as of yet unshipped version of Thor via rails/thor#539 meaning that at some point it will not be necessary to have io/console installed for Bundler. For now, it remains a hard dependency, without which calling Bundler will fail with an error like: /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- io/console (LoadError) from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell/basic.rb:2:in `<top (required)>' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell/color.rb:1:in `<top (required)>' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell.rb:17:in `shell' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/ui/shell.rb:15:in `initialize' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:13:in `new' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:13:in `rescue in start' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:17:in `start' from /usr/local/share/gems/gems/bundler-1.14.6/exe/bundle:32:in `block in <top (required)>' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors' from /usr/local/share/gems/gems/bundler-1.14.6/exe/bundle:24:in `<top (required)>' from /usr/local/bin/bundle:23:in `load' from /usr/local/bin/bundle:23:in `<main>'
Iristyle
added a commit
to Iristyle/puppet
that referenced
this pull request
May 10, 2017
- On Fedora 25, Bundler will outright crash as it has a hard dependency on io/console by way of the Thor CLI library. Bundler 1.14-6 vendors Thor 0.19.1 https://github.com/bundler/bundler/blob/v1.14.6/lib/bundler/vendor/thor/lib/thor/version.rb https://github.com/erikhuda/thor/blob/v0.19.1/lib/thor/shell/basic.rb#L2 The hard dependency has been removed in an as of yet unshipped version of Thor via rails/thor#539 meaning that at some point it will not be necessary to have io/console installed for Bundler. For now, it remains a hard dependency, without which calling Bundler will fail with an error like: /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- io/console (LoadError) from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell/basic.rb:2:in `<top (required)>' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell/color.rb:1:in `<top (required)>' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell.rb:17:in `shell' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/ui/shell.rb:15:in `initialize' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:13:in `new' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:13:in `rescue in start' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:17:in `start' from /usr/local/share/gems/gems/bundler-1.14.6/exe/bundle:32:in `block in <top (required)>' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors' from /usr/local/share/gems/gems/bundler-1.14.6/exe/bundle:24:in `<top (required)>' from /usr/local/bin/bundle:23:in `load' from /usr/local/bin/bundle:23:in `<main>'
This was referenced May 10, 2017
eputnam
pushed a commit
to eputnam/puppet
that referenced
this pull request
Jul 12, 2017
- On Fedora 25, Bundler will outright crash as it has a hard dependency on io/console by way of the Thor CLI library. Bundler 1.14-6 vendors Thor 0.19.1 https://github.com/bundler/bundler/blob/v1.14.6/lib/bundler/vendor/thor/lib/thor/version.rb https://github.com/erikhuda/thor/blob/v0.19.1/lib/thor/shell/basic.rb#L2 The hard dependency has been removed in an as of yet unshipped version of Thor via rails/thor#539 meaning that at some point it will not be necessary to have io/console installed for Bundler. For now, it remains a hard dependency, without which calling Bundler will fail with an error like: /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- io/console (LoadError) from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell/basic.rb:2:in `<top (required)>' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell/color.rb:1:in `<top (required)>' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/shell.rb:17:in `shell' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/ui/shell.rb:15:in `initialize' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:13:in `new' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:13:in `rescue in start' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/cli.rb:17:in `start' from /usr/local/share/gems/gems/bundler-1.14.6/exe/bundle:32:in `block in <top (required)>' from /usr/local/share/gems/gems/bundler-1.14.6/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors' from /usr/local/share/gems/gems/bundler-1.14.6/exe/bundle:24:in `<top (required)>' from /usr/local/bin/bundle:23:in `load' from /usr/local/bin/bundle:23:in `<main>'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.