Lazy-load date & fileutils gems #560

segiddins · 2017-04-25T08:20:18Z

Similar to #539, although the fileutils changes are rather more invasive

Since open-uri.rb requires time.rb which requires date.rb which is a gem as of 2.5

Since fileutils is a gem as of 2.5

Since tempfile requires tmpdir which requires fileutils, which is a gem on 2.5

segiddins · 2017-04-25T15:06:22Z

I dont understand why this is failing, since all of the specs seem to pass

emad-elsaid · 2017-05-04T14:09:03Z

code coverage?

Coverage (91.68%) is below the expected minimum coverage (91.69%).

segiddins · 2017-05-04T21:11:46Z

segiddins added 3 commits April 25, 2017 10:15

Lazy-load open-uri

53919e3

Since open-uri.rb requires time.rb which requires date.rb which is a gem as of 2.5

Lazy-load fileutils

687337a

Since fileutils is a gem as of 2.5

Lazy-load tempfile

2405f6c

Since tempfile requires tmpdir which requires fileutils, which is a gem on 2.5

rafaelfranca merged commit 4b95e2e into rails:master May 4, 2017

segiddins deleted the seg-lazy-load-gems branch May 4, 2017 21:11

Provide feedback