Python 2.7 #22
Python 2.7 #22
Conversation
…nly args to kwargs because python2.7 doesn't support them.
…e @ operator that I missed.
|
Also, in the setup section of the README, can you remove the blurb about |
README.rst
Outdated
| * Install ``python3.6`` -- This repo is currently only tested with/officially supports ``python3.6`` | ||
|
|
||
| All further instructions assume that `python` defaults to ``python3.6`` | ||
| * Install ``python3.6`` |
There was a problem hiding this comment.
| * Install ``python3.6`` | |
| * Install ``python`` -- This repo is tested with ``2.7``, ``3.4``, ``3.5``, and ``3.6`` |
There was a problem hiding this comment.
I don't remember if 3.4 was a typo of 3.5 when I added it to tox.ini or whether I tested both. I'm going to run the setup and tests one more time on 3.4.9 and 3.5.6 just to be absolutely sure that it's good, but there's no reason it shouldn't be that I know of.
There was a problem hiding this comment.
3.4 was definitely a typo because torch 1.0.0 doesn't have a package for that version. I must have tested on 2.7 and then 3.6 twice.
$ pip3.4 install torch
Collecting torch
Using cached https://files.pythonhosted.org/packages/5f/e9/bac4204fe9cb1a002ec6140b47f51affda1655379fe302a1caef421f9846/torch-0.1.2.post1.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/tmp/pip-build-hplx_sgk/torch/setup.py", line 11, in <module>
raise RuntimeError(README)
RuntimeError: PyTorch does not currently provide packages for PyPI (see status at https://github.com/pytorch/pytorch/issues/566).
Please follow the instructions at http://pytorch.org/ to install with miniconda instead.
3.5 builds and passes tests now, 2.7 and 3.6 still pass and I've removed 3.4 from the readme and tox.ini.
…d the line that supplies a traceback from the exception re-raise in pytorch_utils.py, as python3.5 doesn't support supplying a traceback.
|
This looks great! Thank you very much for your contributions :) |
Made changes for python 2.7 compatibility, bumped minor version.
Resolves #21
Resolves #18