Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User settings #643

Merged
merged 3 commits into from
Sep 14, 2020
Merged

User settings #643

merged 3 commits into from
Sep 14, 2020

Conversation

erincatto
Copy link
Owner

@erincatto erincatto commented Sep 7, 2020 •
edited
Loading

TODO: is there a CMake mechanism I should provide for users to define B2_USER_SETTINGS?

This was referenced Sep 7, 2020
Closed
Closed
MathewMacDougall
MathewMacDougall approved these changes Sep 11, 2020
View reviewed changes
Copy link

@MathewMacDougall MathewMacDougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, I like the idea of b2_lengthUnitsPerMeter

@erincatto erincatto merged commit f0f9d50 into master Sep 14, 2020
@erincatto erincatto deleted the erincatto/issue_559 branch September 14, 2020 05:52
@Birch-san Birch-san mentioned this pull request Oct 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathewMacDougall MathewMacDougall MathewMacDougall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erincatto @MathewMacDougall