-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import feature? #4
Comments
Thank you for the nice words. |
It looks like we need a parser for the DOT Language. |
i wrote a DOT parser. it has a few TODOs still. i think the main issue is it can't parse HTML nodes, and it can't handle arbitrarily placed comments. i looked at this package for html parsing, but it only exposes the i've never written a serious parser in Elm, so maybe @jinjor or someone could look it over. |
Great! |
thanks to @hecrj, i think the parser is thoroughly implemented now! i plan to do more testing and write some comments/docs, but we should be able to move forward on this feature soon. |
🎉I don't know much about parsers but the code looks very clean and nice. I am not going to be able to work on this for a while. Of course, if you make a pull request, I will merge. I never used elm/file but it looks like the library to use. Or maybe just a text field? |
here's what i'm thinking:
does that all sound right? |
The elm community graph package already has a few graph to * converters,
and you could probably just use those.
I think it makes sense to put the dot to graph converter in that repo too,
as that would be very useful.
…On Thu, Feb 28, 2019, 4:00 PM Matthew Brandly ***@***.***> wrote:
here's what i'm thinking:
- we need Dot -> Graph for importing
- we need Graph -> Dot and Dot -> String for exporting.
- toString : Dot -> String can be part of my repo. i'm not sure where
the Dot/Graph converters should live.
- elm/file would be good to integrate. a <textarea> might also be
nice, for those who are familiar with DOT and can write it by hand. the
textarea is easier to implement, so we could start there.
does that all sound right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABva0xX3kV4hVoIC25ILYDJ1CwHBkllYks5vSF-QgaJpZM4aw3BA>
.
|
i see this my repo could also have a @sgraf812 are you interested in |
Hey, sorry to be so late to the discussion. I'm generally a little sceptical of adding any more importing/exporting functionality and think they should rather go in seperate packages. Things aren't so bad when it's just some hacky So: I'd be happy to see a function |
If this functionality ends up in a separate package, I'd prefer it to be stand-alone (as opposed to a part of |
there's some discussion here where it looks like we'll be going between
i agree. this should exist. i'm not sure where it'll live. i haven't published i'm glad that there's wider interest in these components! |
After you publish I will try to do it in such a way, that the field names coincide with the property names that are used by GraphViz. So that, if one wants to transport his/her graph from Kite to Graphviz, this would be helpful. |
thanks @erkal! i should have time to write out more docs and get it published soon. i'll try to get an initial version out before writing after we see how that goes, i can add |
@erkal i published i already added looking forward to seeing this come together! |
Great! ❤️ |
Ok, now it is in progress |
i see that |
I checked those boxes maybe too early. :) But I am going to push something in a couple of days. I will send you a message when I do. |
Hey @brandly, I pushed a branch: using-dotlang |
idea: since there will undoubtedly be graphviz properties that aren't first-class properties in Kite, we could hold these extraneous properties in a i haven't looked at how feasible this is at an implementation level. maybe it complicates things more than it's worth. |
We already have But only a |
Ok, the local storage uses now DotLang instead of json. |
Very cool tool! I've been using online graphviz projects like https://dreampuf.github.io/ for many uses, but I would like more interactivity, such as what you provide.
I saw a plan for exporting different formats, but how about import DOT format? Or at least have a DOT editor. I find it easier to create graphs (especially when I want to specify labels/colors/etc) that way. Also, most graph libraries can export to different formats such as DOT (this is true for the elm graph library too - I'm the one who originally added it!).
Thanks for considering this feature, and great work!
The text was updated successfully, but these errors were encountered: