Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding documentation #5

Closed
kevinirlen opened this issue May 10, 2024 · 3 comments · Fixed by #6
Closed

Regarding documentation #5

kevinirlen opened this issue May 10, 2024 · 3 comments · Fixed by #6
Assignees

Comments

@kevinirlen
Copy link
Contributor

Hi,

Thanks for this bundle.

I have a question regarding the documentation.. It says

First thing to do is make a new service that implements Erkens\Security\TwoFactorTextBundle\Generator\CodeGeneratorInterface so we can actually send a sms or text message. This service can then be used in the configuration as "auth_code_sender":

Is this correct? The bundle already have a CodeGenerator implementation.

Maybe the documentation should read as follows

First thing to do is make a new service that implements Erkens\Security\TwoFactorTextBundle\TextSender\AuthCodeTextInterface so we can actually send a sms or text message. This service can then be used in the configuration as "auth_code_sender":

Thoughts?

Cheers.

@kevinirlen
Copy link
Contributor Author

kevinirlen commented May 21, 2024

@erkens can you please check it?

@erkens
Copy link
Owner

erkens commented May 22, 2024

I think you are right :)

@erkens erkens self-assigned this May 22, 2024
erkens added a commit that referenced this issue May 22, 2024
@erkens erkens linked a pull request May 22, 2024 that will close this issue
@erkens erkens closed this as completed in #6 May 22, 2024
erkens added a commit that referenced this issue May 22, 2024
@kevinirlen
Copy link
Contributor Author

Thanks for reviewing @erkens and thanks for the good jb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants