Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics window canvases don't fill the window #12

Closed
curiousdannii opened this issue Oct 6, 2016 · 5 comments
Closed

Graphics window canvases don't fill the window #12

curiousdannii opened this issue Oct 6, 2016 · 5 comments

Comments

@curiousdannii
Copy link
Contributor

curiousdannii commented Oct 6, 2016

glkote screenshot

another screenshot

This is surely due to some finicky css default rule. I haven't figured out yet how it should be fixed.

@erkyrath
Copy link
Owner

(Problem is the darker-blue line at the bottom edge. Or black on newer builds.)

@curiousdannii
Copy link
Contributor Author

I'm pretty sure it's the space between the baseline and the bounding box, because the canvas is inline. Maybe all that needs changing is making it block? But I don't know what else that would affect.

@erkyrath
Copy link
Owner

Nothing else that I can think of. I will accept this as the right answer. :)

I'm pretty sure I thought canvas was display:block by default, when I wrote this code.

@erkyrath
Copy link
Owner

Try f2a84f2 in your setup, see if it fixes the problem.

@curiousdannii
Copy link
Contributor Author

Yep looks good to me.

I thought I had seen in the style sheets that it had been explicitly set to display: inline, but I must've just imagined it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants