Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flexbox for input element instead of calculating width manually #40

Closed
wants to merge 1 commit into from

Conversation

juhana
Copy link
Contributor

@juhana juhana commented Sep 16, 2019

plus some other modern CSS features

@curiousdannii
Copy link
Contributor

curiousdannii commented Sep 16, 2019

This should probably be made at https://github.com/erkyrath/glkote

Does this fix the bug of #32? Or is something like erkyrath/glkote#28 also needed?

@juhana
Copy link
Contributor Author

juhana commented Sep 16, 2019

Oops, didn't notice that Glkote has a separate repo. (It could be added as a subrepository here to avoid the need for syncing it manually.)

I don't think this fixes the Android bug, I assume the problem is removing and re-adding the input field? I can try it though. This is in response to https://intfiction.org/t/quixe-chrome-cursor-position/42413

@juhana
Copy link
Contributor Author

juhana commented Sep 16, 2019

There doesn't seem to be any difference in Android, although it's not as bad as #32 describes: City of Secrets doesn't get stuck anymore but the keyboard bounces up and down between turns.

@erkyrath
Copy link
Owner

Closing this, as it doesn't seem to do what we need and the Chrome bug has been fixed already. See comments at erkyrath/glkote#36 .

@erkyrath erkyrath closed this Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants