Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maybe not reflected in erl_parse:abstract_expr/0 #6956

Closed
erszcz opened this issue Mar 1, 2023 · 0 comments · Fixed by #7013
Closed

maybe not reflected in erl_parse:abstract_expr/0 #6956

erszcz opened this issue Mar 1, 2023 · 0 comments · Fixed by #7013
Assignees
@bjorng
Labels
bug Issue is reported as a bug team:VM Assigned to OTP team VM

Comments

@erszcz
Copy link
Contributor

erszcz commented Mar 1, 2023

There's rudimentary support for maybe in Gradualizer so that the tool doesn't crash, but rather report it can't type check the expression yet. However, since maybe is not part of its gradualizer_type:abstract_expr/0 originally based on erl_parse:abstract_expr/0 and updated to match Erlang 24, Gradualizer doesn't self-check correctly. I wanted to borrow maybe references from the post Erlang 25 erl_parse:abstract_expr/0, but it seems there are none, although the new keyword is now added to the Erlang grammar definition.
@erszcz erszcz added the bug Issue is reported as a bug label Mar 1, 2023
@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Mar 6, 2023
@bjorng bjorng mentioned this issue Mar 13, 2023
Merged
@bjorng bjorng linked a pull request Mar 13, 2023 that will close this issue
erl_parse: Update types #7013
Merged
@bjorng bjorng closed this as completed in 6f9420c Mar 15, 2023
bjorng added a commit that referenced this issue Mar 15, 2023
@bjorng
Merge branch 'bjorn/stdlib/erl_parse/GH-6956/OTP-18506' into maint
33ed1d8 
* bjorn/stdlib/erl_parse/GH-6956/OTP-18506:
  erl_parse: Update types
u3s pushed a commit that referenced this issue Apr 27, 2023
Merge branch 'bjorn/stdlib/erl_parse/GH-6956/OTP-18506' into maint-25
986e970 
* bjorn/stdlib/erl_parse/GH-6956/OTP-18506:
  erl_parse: Update types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjorng bjorng

Labels
bug Issue is reported as a bug team:VM Assigned to OTP team VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

erl_parse: Update types bjorng/otp
3 participants
@bjorng @erszcz @rickard-green