Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erl_parse: Update types #7013

Merged

Conversation

bjorng
Copy link
Contributor

@bjorng bjorng commented Mar 13, 2023

  • The binary_op() type was missing the ! operator.
  • The abstract_expr() was missing the maybe construct.

Closes #6956

* The `binary_op()` type was missing the `!` operator.
* The `abstract_expr()` was missing the `maybe` construct.

Closes erlang#6956
@bjorng bjorng added team:VM Assigned to OTP team VM fix labels Mar 13, 2023
@bjorng bjorng self-assigned this Mar 13, 2023
@bjorng bjorng linked an issue Mar 13, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023

CT Test Results

       2 files       85 suites   33m 53s ⏱️
1 704 tests 1 654 ✔️ 47 💤 3
1 981 runs  1 929 ✔️ 49 💤 3

For more details on these failures, see this check.

Results for commit 6f9420c.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

erszcz added a commit to erszcz/Gradualizer that referenced this pull request Mar 14, 2023
@bjorng bjorng merged commit 33ed1d8 into erlang:maint Mar 15, 2023
@erszcz
Copy link
Contributor

erszcz commented Mar 15, 2023

Thank you!

@bjorng bjorng deleted the bjorn/stdlib/erl_parse/GH-6956/OTP-18506 branch June 9, 2023 05:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maybe not reflected in erl_parse:abstract_expr/0
2 participants