Early Visual Studio 2017 compilation supports & intructions #1447
Conversation
Changes the visual studio 2017 and sdk path on cygwin .bash_profile
Fixed compile error on visual studio 2015 and above caused by already defined static types.
|
Thanks. I don't want to change the instructions/recommendations of how to build on windows, For now make a gist or add an entry on the wiki so it's not completely forgotten. I think I will change the wx gl typedef and close this PR? And yes we need to fix the scripts to locate the vcredist installer, but I don't have time for that now. |
| typedef int int32_t; | ||
| typedef __int64 int64_t; | ||
| typedef unsigned __int64 uint64_t; | ||
| #elif _MSC_VER < 1900 | ||
| typedef long int int32_t; |
There was a problem hiding this comment.
Why not only change it to:
typedef __int32 int32_t;
There was a problem hiding this comment.
I was only copying the new static types from the new vs 2017 header file. My knowledge doesn't quite up to par with the your change :-(
|
Fair enough, i merely self compiled it because of new changes from github that i am needed and possible windows's assemblies binary fixes and optimization in above vs 2013. Possibly you could add my instruction changes into the erlang's github wikis?. |
|
Fixed compilation and added link to this PR in wiki |
Tested with compiling latest erlang x64 master branch's commit on visual studio 2017 enterprise
The only last remaining problem is
src\otp\erts\etc\win32\nsis\find_redist.sh seems failed to finding
"vcredist_x64.exe"which is located in
The cl.exe for msvc 2017 enterprise is located in
Based on old INSTAL_WIN32.md direction of recommending visual studio 12.0
or 2013, the cl.exe location for msvc 2013 x64 is :
And the vcredist_x64.exe for msvc 2013 is :
When running "./otp_build installer_win32" i have got the following
error "Failed to locate vcredist_x64.exe because cl.exe was in an
unexpected location".
Any of erlang windows developer wanted to add some more info about
these problems?.