Emacs indent tests and fixes #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, I'm worried that this changes the way some arguments are indented. See here for a diff using your branch's code. |
|
The new looks better than the old so it was intentional :-) |
|
While we are on fixes, How hard would be to disable indenting of multi-line string literals? this: ?assertMatch(<<"# TYPE video_count counter
# HELP video_count number of videos processed processed over time
video_count{ctag=\"value\",type=\"mpeg\"} 2
# TYPE video_sum summary
# HELP video_sum video_size_sum
video_sum_count{sum_tag=\"value\",category=\"category1\",type=\"mpeg\"} 2
video_sum_sum{sum_tag=\"value\",category=\"category1\",type=\"mpeg\"} 5120
# TYPE video_size histogram
# HELP video_size number of videos processed processed over time
video_size_bucket{ctag=\"value\",le=\"0\"} 0
video_size_bucket{ctag=\"value\",le=\"65536\"} 2
video_size_bucket{ctag=\"value\",le=\"4294967296\"} 2
video_size_bucket{ctag=\"value\",le=\"+Inf\"} 2
video_size_count{ctag=\"value\"} 2
video_size_sum{ctag=\"value\"} 5120
# TYPE last_video_size gauge
# HELP last_video_size last processed video size
last_video_size{ctag=\"value\"} 4096
">>, prometheus_text_format:format()).will be indented to this: ?assertMatch(<<"# TYPE video_count counter
# HELP video_count number of videos processed processed over time
video_count{ctag=\"value\",type=\"mpeg\"} 2
# TYPE video_sum summary
# HELP video_sum video_size_sum
video_sum_count{sum_tag=\"value\",category=\"category1\",type=\"mpeg\"} 2
video_sum_sum{sum_tag=\"value\",category=\"category1\",type=\"mpeg\"} 5120
# TYPE video_size histogram
# HELP video_size number of videos processed processed over time
video_size_bucket{ctag=\"value\",le=\"0\"} 0
video_size_bucket{ctag=\"value\",le=\"65536\"} 2
video_size_bucket{ctag=\"value\",le=\"4294967296\"} 2
video_size_bucket{ctag=\"value\",le=\"+Inf\"} 2
video_size_count{ctag=\"value\"} 2
video_size_sum{ctag=\"value\"} 5120
# TYPE last_video_size gauge
# HELP last_video_size last processed video size
last_video_size{ctag=\"value\"} 4096
">>, prometheus_text_format:format()). |
|
@deadtrickster Sounds like ERL-210: |
|
I'm not alone, yay! |
Split the manual testcase and run them in daily tests instead. Easy to run directly as well: (cd ../test; cerl -eval "emacs_SUITE:indent([])")
Avoid
From:
{
^^element1,
^^element2
}
To:
{
^element1,
^element2
}
dgud
force-pushed
the
dgud/tools/emacs/indent-tests
branch
from
83c3ed5
to
13f1dec
Compare
This was referenced Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move emacs indentation to test suite.
Also fixes a couple of the issues found.