Add Erlang alignment regexps #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These allow for the alignment of maps and records
|
Is there some initialization missing or is this new functionality? I assume this replaces #1707 |
|
When testing on some files I noticed that it's missing ':=' for maps. |
|
Hi there, noticed this patch brings some regressions now that #1681 is merged: |
|
@fenollp I'm looking, but... I don't see how my patch and that one even interact? My patch is for maps and records. I'm not familiar with that test suite - is there some advice on how I could run it locally to check? |
|
Merged, Thanks |
velimir
added a commit
to velimir/otp
that referenced
this pull request
Aug 28, 2018
erlang-mode crashes with the following error: Symbol’s value as variable is void: align-rules-list caused by erlang#1728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These allow for the alignment of maps and records with the Emacs
aligncommand.I think this may be a better, more 'emacsy' way of doing things than this:
#1707