Fix inet driver realloc bug #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only SCPT should keep the recv buffer when going into select. If UDP does it, it will result in many more memory allocations than there should be which can be very detrimental to performance.
legoscia
reviewed
Jul 17, 2018
lib/kernel/doc/src/inet.xml
Outdated
| Kernel socket buffers. It is recommended | ||
| to have <c>val(buffer) >= max(val(sndbuf),val(recbuf))</c> to | ||
| Kernel socket buffers. For TCP it is recommended | ||
| to have <c>val(buffer) >= max(val(recbuf))</c> to |
There was a problem hiding this comment.
No need for max here when there is only one value.
There is no reason to have a larger buffer than this as the recvmsg call will never return more data. OTP-15206
garazdawi
force-pushed
the
lukas/erts/fix_udp_realloc_bug
branch
from
4e8f1d1
to
a9d361b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the performance issues found in the erlang-questions discussion here: http://erlang.org/pipermail/erlang-questions/2018-May/095494.html
The PR does two things: