Allow changing source paths presented in stack traces #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this does *not* affect -include()'d files or the -file() directive.
The source file path as given to `erlc` was included in an implicit file attribute inserted by epp, even when the +source flag was set to something else which was a bit surprising. It was also included when +deterministic was specified, breaking the flag's promise. This commit forwards the +source flag to epp so it inserts the right information, and if +deterministic is given it will be shaved to just the base name of the file, guaranteeing the same result regardless of how the input is reached.
|
Nice. And that implicit file attribute is what is used when generating stacktraces as well? |
|
Yep! Before: After: |
|
Nice, that sounds like exactly the kind of thing we needed for rebar3 then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pre-processing a file,
eppwill automatically insert-file()attributes to let the compiler know what file an expression belongs to. This information is then used in error reports and stack traces.The current behavior is that the pre-processor will always use the path as passed to
erlcfor these attributes, so the only way to prevent leaking information about the build environment is to invokeerlcin the folder the source file resides in.This PR aims to remedy that. When the
+sourceflag is given the pre-processor will use that instead of the actual file path for these attributes. It also fixes a related bug in the+deterministicflag.https://bugs.erlang.org/browse/ERL-706