Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arity-1 versions of atom_to_binary, binary_to_atom and binary_to_existing_atom #2358

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

sverker
Copy link
Contributor

@sverker sverker commented Aug 23, 2019

All with utf8 encoding as implicit second argument.

All auto-imported like their arity-2 counterparts already are.

@sverker sverker self-assigned this Aug 23, 2019
@sverker sverker added feature team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI labels Aug 23, 2019
@michalmuskala
Copy link
Contributor

Would it make sense to apply the compiler optimisations from the /2 variants into the /1 as well? In particular the partial evaluation one where calls with literal arguments are evaluated at conpile-time.

@sverker
Copy link
Contributor Author

sverker commented Aug 26, 2019

@michalmuskala Yes, that makes sense. Thank you.

and binary_to_existing_atom/1

All with default utf8 encoding.
@sverker sverker force-pushed the sverker/binary-to-atom-1/OTP-15995 branch from c95f242 to 2921dfa Compare August 29, 2019 13:16
@sverker sverker merged commit 6f0ad85 into erlang:master Aug 29, 2019
@sverker sverker removed the testing currently being tested, tag is used by OTP internal CI label Aug 29, 2019
@sverker sverker deleted the sverker/binary-to-atom-1/OTP-15995 branch June 16, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants