Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using custom IO devices in logger_std_h #2523

Merged

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Jan 31, 2020

This is needed for simpler integration with Elixir logger which allows any device to be set as an output device. It also provides greater flexibility when needed to integrate with log catchers.

This is needed for simpler integration with Elixir logger which allows
any device to be set as an output device. It also provides greater
flexibility when needed to integrate with log catchers.
@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Feb 3, 2020
@garazdawi
Copy link
Contributor

I think that the type you want to include is io:device(). The file:io_device() type includes what is returned by file:open(Path,[raw]) which I don't think will work in this case.

@hauleth
Copy link
Contributor Author

hauleth commented Feb 4, 2020

Yeah, that was probably the type I wanted. I will update the data.

@hauleth hauleth force-pushed the ft/allow-different-io-devices-in-logger branch 2 times, most recently from 6efef4d to bc34465 Compare February 4, 2020 11:36
@hauleth hauleth force-pushed the ft/allow-different-io-devices-in-logger branch from bc34465 to d68a221 Compare February 4, 2020 12:43
@garazdawi garazdawi added the testing currently being tested, tag is used by OTP internal CI label Mar 9, 2020
@garazdawi garazdawi merged commit d333423 into erlang:master Mar 23, 2020
@hauleth hauleth deleted the ft/allow-different-io-devices-in-logger branch March 23, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants