Explicit pass RPO to beam_ssa functions (cont) #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorng
requested changes
Nov 4, 2020
This patch finishes the work started on 0ce3fb9 by explicitly passing RPO to the remaining functions in beam_ssa. This commit avoids the double RPO computation in 5 other occasions.
josevalim
force-pushed
the
jv-explicit-rpo-2
branch
from
f306cf4
to
35f10ba
Compare
bjorng
approved these changes
Nov 4, 2020
|
Added to our daily builds. |
|
Thanks for this pull request. |
|
Btw, with all 4 PRs combined, the Unicode module in Elixir compiles 18% faster on machine, which is pretty neat! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch finishes the work started on 0ce3fb9
by explicitly passing RPO to the remaining functions
in beam_ssa. This commit avoids the double RPO
computation in 4 other occasions.