Fix process stack in crashdump #5462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OTP-23 the format of the stackdump was inadvertenly changed so that all variables in the first frame are prefixed with an address instead of y register. This commit makes cdv handle the new and old format.
In OTP-23 the placement of the top frame was changed and that
caused the stackdump printing algorithm to not prefix variables
in the first frame with y. i.e.
0x00007f72440b76f0:N
0x00007f72440b76f8:SReturn addr 0x44381898 (proc_lib:init_p_do_apply/3 + 72)
y0:P<0.9.0>
y1:P<0.10.0>
0x00007f72440b7718:SReturn addr 0x66325748 (<terminate process normally>)
was written instead of
y0:N
0x00007f72440b76f8:SReturn addr 0x44381898 (proc_lib:init_p_do_apply/3 + 72)
y0:P<0.9.0>
y1:P<0.10.0>
0x00007f72440b7718:SReturn addr 0x66325748 (<terminate process normally>)
The same issue was also fixed for erlang:process_display,
erlang:process_info(backtrace) and the ctrl-c proc dump.
garazdawi
added
the
testing
bjorng
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimization in #2351 inadvertently changed the way that the first stackframe in crash dumps is displayed. This PR fixes that problem in crash dumps and updates crash dump viewer to be able to read the stackframe of the broken processes.
Problem was also reported in #5459