erts: Apply -fno-omit-frame-pointer to erts/lib_src when JIT is enabled #6048
Conversation
|
|
CT Test Results 4 files 135 suites 51m 20s ⏱️ Results for commit 1bc6daf. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Hello! Thanks for the PR! Would you mind signing the CLA? |
Done! |
There was a problem hiding this comment.
You need to also change erts/configure.ac to include flavor.mk.in as erts/configure is a generated file.
Thanks for the comment! I included the requested change in [erts/configure.ac]. |
|
@garazdawi I made the requested change. Can I ask for a quick review? Thanks! |
|
@d1jang: I am afraid @garazdawi is on vacation until mid August. Maybe someone else in the team can find the time to have a look, but do not hold your breath... |
garazdawi
added
testing
|
Hello again! The changes in this PR break the building of a non-jit emulator. To reproduce run: |
garazdawi
force-pushed
the
apply_no_omit_frame_pointer_to_erts_lib_src
branch
2 times, most recently
from
91f55a2
to
1bc6daf
Compare
|
I've pushed changes to your branch to fix the issues and add CI in order to check that the different types and flavors works. |
garazdawi
added
the
testing
garazdawi
force-pushed
the
apply_no_omit_frame_pointer_to_erts_lib_src
branch
from
1bc6daf
to
73a7588
Compare
Currently OMIT_OMIT_FP is set to true in erts/emulator/Makefile.in
when JIT is enabled, but not necessarily in erts/lib_src/Makefile.in.
This change factors out OMIT_OMIT_FP computation to be shared between
those two builds to apply this flag consistently to them.
Note that this bug was confirmed by @garazdawi in an Erlang forum post: https://erlangforums.com/t/unify-builds-for-otp-erts-targets/1419/3