Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlink issues #6150

Merged

Conversation

rickard-green
Copy link
Contributor

An unlink operation made by a process that terminated before the unlink operation completed, i.e., before it had received an unlink-ack signal from the linked process, caused an exit signal to erroneously be sent from the terminating process to the process being unlinked. This exit signal would most often be ignored by the receiver, but if the receiver of the exit signal concurrently set up a new link, it could receive the exit signal with the actual exit reason of the terminating process instead of a noproc exit reason. It is however very hard to detect that this has happened and has no obvious negative consequences, so it should be considered harmless.

A distributed unlink-ack signal received by a terminating process was also not properly removed which could cause a minor memory leak.

…unlink-exit-fix/24.3.4/OTP-18177

* rickard/unlink-exit-fix/23.3.4/OTP-18177:
  [erts] Fix dist unlink-id-ack signal memory leak
  [erts] Don't send exit signal due to a link with ongoing unlink op
…unlink-exit-fix/OTP-18177

* rickard/unlink-exit-fix/24.3.4/OTP-18177:
  [erts] Fix dist unlink-id-ack signal memory leak
  [erts] Don't send exit signal due to a link with ongoing unlink op
@rickard-green rickard-green added team:VM Assigned to OTP team VM fix testing currently being tested, tag is used by OTP internal CI labels Jul 13, 2022
@rickard-green rickard-green self-assigned this Jul 13, 2022
@rickard-green rickard-green added this to the OTP-25.0.3 milestone Jul 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022

CT Test Results

       3 files     125 suites   36m 26s ⏱️
1 451 tests 1 409 ✔️ 42 💤 0
1 750 runs  1 691 ✔️ 59 💤 0

Results for commit e74ae5b.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@rickard-green rickard-green merged commit a3db84d into erlang:maint-25 Jul 15, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant