named_fun_expr annotate bindings fix #6523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the PR! It looks good, and I'll add it to our nightly tests once 25.2 is released. :) |
jhogberg
added
the
testing
CT Test Results 2 files 13 suites 3m 35s ⏱️ Results for commit 3609146. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Merged, thanks again for the PR! :) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the behavior of
erl_syntax_lib:annotate_bindings/1-2described in #4733 (labeled with "help wanted").Issue is also mentioned in
erlang_lsrepo, so potential fix may also allow better UX while using it.Description:
My plan was to include a case in
vann/2function to handlenamed_fun_exprnodes correctly. Annotation process is almost identical to the one offun_expr, obviously with the difference of handlingnamed_fun_expr's name. Name of the function is set into the environment for each of the clause patterns, because patterns can shadow the function name.I included one concrete example for the testing purpose.
GitHub actions passed successfully on the fork repo.