os_mon: Close cpu_sup and memsup port on terminate

[jdamanalo]

Closes #4221

There seems to be a similar issue with memsup. Should I include it here?

[github-actions]

CT Test Results

    2 files    15 suites   3m 30s ⏱️
111 tests 108 ✔️ 3 💤 0 ❌
130 runs  127 ✔️ 3 💤 0 ❌

Results for commit 00cfb44.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• Windows Installer

// Erlang/OTP Github Action Bot

[jdamanalo]

Added closing of memsup too.

I considered closing cpu_sup using stop() as mentioned in the issue but I am unsure if it is actually working as intended (It does not seem to bubble up until the internal port). Also, it is unused by os_mon. Hence, I decided to just close it on the exit signal. Maybe it can be removed?

I also added more context in the open issue.

[rickard-green]

Thanks for the PR. I've pushed a commit that

• only send the quit message to the cpu_sup port server when we actually have a port server which prevents an error being logged in the case we do not have a port server
• removed the receive of the never sent quit message in the cpu_sup measurement server
• takes care of all places where the close message can be received in the memsup port handler process

Please squash this commit with your commit and force push it.

[jdamanalo]

Squashed and rebased. Thanks for getting what I missed! 😅