Fix hipe bug when matching a writable binary #690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seen symptom: Hipe compiled code with <<C/utf8, ...>> = Bin does sometimes not match even though Bin contains a valid utf8 character. There might be other possible binary matching symptoms, as the problem is not utf8 specific. Problem: A writable binary was not "emasculated" when the matching started (as it should) by the hipe compiled code. Fix: Add a new primop emasculate_binary(Bin) that is called when a matchstate is created. ToDo: There are probably room for optimization. For example only call emasculate_binary if ProcBin.flags is set.
|
Thanks! The patch fixes the bug for us! http://erlang.org/pipermail/erlang-bugs/2015-April/004910.html |
|
amazing! |
|
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
Only call emasculate_binary if ProcBin.flags is set, which means it's a writable binary.
|
I did the optimization of checking ProcBin.flags. |
|
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
|
I ran our application test suite successfully with e40aab7. |
|
I reviewed both commits and tested them with the HiPE test suite on top of otp 17.5: no regressions. Thanks for fixing this. |
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a hipe problem reported by Johannes Weißl and Sebastian Egner:
http://erlang.org/pipermail/erlang-bugs/2015-April/004884.html
Seen symptom: Hipe compiled code with
<<C/utf8, ...>> = Bindoes sometimesnot match even though Bin contains a valid utf8 character. There might be
other possible binary matching symptoms, as the problem is not utf8
specific.
Problem: A writable binary was not "emasculated" when the matching started
(as it should) by the hipe compiled code.
Fix: Add a new primop emasculate_binary(Bin) that is called when
a matchstate is created.
ToDo: There are probably room for optimization. For example only call
emasculate_binary if ProcBin.flags is set.