Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hipe bug when matching a writable binary #690

Closed
wants to merge 2 commits into from

Commits on Apr 20, 2015

  1. erts,hipe: Fix bug in binary matching of writable binary

    Seen symptom: Hipe compiled code with <<C/utf8, ...>> = Bin does sometimes
    not match even though Bin contains a valid utf8 character. There might be
    other possible binary matching symptoms, as the problem is not utf8
    specific.
    
    Problem: A writable binary was not "emasculated" when the matching started
    (as it should) by the hipe compiled code.
    
    Fix: Add a new primop emasculate_binary(Bin) that is called when
    a matchstate is created.
    
    ToDo: There are probably room for optimization. For example only call
    emasculate_binary if ProcBin.flags is set.
    sverker committed Apr 20, 2015
    Configuration menu
    Copy the full SHA
    91fb663 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2015

  1. erts,hipe: Optimize away calls to emasculate_binary

    Only call emasculate_binary if ProcBin.flags is set,
    which means it's a writable binary.
    sverker committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    e40aab7 View commit details
    Browse the repository at this point in the history