erts: Reintroduce literal fun optimization #6963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhogberg
added
team:VM
CT Test Results 3 files 133 suites 50m 2s ⏱️ Results for commit 05cd4bc. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
The optimization that turned make_fun2/3 instructions of funs lacking an environment into literals was lost during the pre-JIT refactoring of the loader, as creation of fun entries was now (rightly) deferred until the very last stages of module loading. This commit restores that optimization by creating placeholders in the form of external funs, which are then converted to local funs during the last stages of module loading.
jhogberg
force-pushed
the
john/erts/reintroduce-literal-lambdas/OTP-18498
branch
from
70f53fd
to
7532e1d
Compare
bjorng
approved these changes
Mar 3, 2023
jhogberg
force-pushed
the
john/erts/reintroduce-literal-lambdas/OTP-18498
branch
2 times, most recently
from
ad191d1
to
69fff7c
Compare
jhogberg
force-pushed
the
john/erts/reintroduce-literal-lambdas/OTP-18498
branch
from
69fff7c
to
05cd4bc
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimization that turned
make_fun2/3instructions of funs lacking an environment into literals was lost during the pre-JIT refactoring of the loader, as creation of fun entries was now (rightly) deferred until the very last stages of module loading.This commit restores that optimization by creating placeholders in the form of external funs, which are then converted to local funs during the last stages of module loading.