Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make multiline prompt invert-colored spaces. #7564

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

attah
Copy link
Contributor

@attah attah commented Aug 16, 2023

This way it is syntactically correct, as opposed to '..'.

Fixes #7558

I got only one failure in stdlib tests, which was in ssh, and seemed unrelated.
Maybe i missed where it was tested still somehow, or there were no tests.

Screenshot from 2023-08-16 10-20-28

This way it is syntactically correct, as opposed to '..'.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

CT Test Results

       3 files     143 suites   1h 39m 25s ⏱️
3 281 tests 2 992 ✔️ 289 💤 0
3 788 runs  3 449 ✔️ 339 💤 0

Results for commit fb7d62c.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@jhogberg jhogberg added the team:VM Assigned to OTP team VM label Aug 16, 2023
@frazze-jobb frazze-jobb self-assigned this Aug 21, 2023
@frazze-jobb
Copy link
Contributor

frazze-jobb commented Aug 21, 2023

Regarding test,
There are two occurances in kernel/src/interactive_shell_SUITE.erl
shell_multiline_navigation
shell_receive_standard_out

Nice idea with inverted colors!

@attah
Copy link
Contributor Author

attah commented Aug 21, 2023

Aha! I was looking in stdlib where the change was. ...and seemingly tests here passed?
I had an initial look (with at least one failure), and let's just say i need to spend more time on it :)
I'm starting to doubt very much that the ".." in the test is actually matching literal "..", but just any two characters.

Thanks!
People tend to be particular with their terminal colors, so a relative color seemed safer than an absolute.

@attah
Copy link
Contributor Author

attah commented Aug 22, 2023

I'm getting nowhere fast with this.
I only get a failure in "shell_receive_standard_out", and something about how it is testing breaks with the escape sequences.
My understanding is that it is testing that the newline (and newline indicator) remains where it should even after the fun has printed some stuff before it, while the user had not finished writing.
This works fine "IRL", but in the test the newline indicator is borked and incomplete:

0
1
2
3
4
(�[94m한국어/조선말�[39m)4> ABC
               �[7m  �[0m�[39m�[49m

Compared to the old output of:

0
1
2
3
4
(�[94m한국어/조선말�[39m)4> ABC
               ..

@frazze-jobb
Copy link
Contributor

I will have a look

@frazze-jobb frazze-jobb added the testing currently being tested, tag is used by OTP internal CI label Aug 23, 2023
@frazze-jobb frazze-jobb merged commit 7b0c273 into erlang:maint Aug 24, 2023
16 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants