-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EEP 65: -import_type directive #7618
base: maint
Are you sure you want to change the base?
Conversation
CT Test Results 4 files 122 suites 55m 51s ⏱️ Results for commit 51889c6. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
066de00
to
621e52f
Compare
How is |
The EEP erlang/eep#51 provides the motivation. Let me try to explain the motivation from the EEP using the example, assuming that the local type alias
To summarize: the differences are mostly about consistency and ergonomics when working with code. |
you can expect some updates regarding this PR by the end of the week |
There are a couple of tools that I think would need updating (or at least test cases added) before this PR is merged. A none-complete list is:
Non-OTP tools that will also be effected (just listed here for reference):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are small nitpicks to consider.
I can review the PR again once the changes requested by @garazdawi have been addressed.
5ba14cc
to
cd7fcc4
Compare
b568c79
to
bd340fb
Compare
bd340fb
to
51889c6
Compare
@kikofernandez - I have added edoc integration, - it works through keeping the mapping of imported types and using them in as @garazdawi mentioned - erl_docgen works then out of the box, - I have tested it with the |
I am not sure what to do about the following items:
Any advice would be much appreciated! |
I would expect erl_syntax, erl_syntax_lib and prettypr to need functionality similar to what they have for
Check that the syntax highlighting and flymake works the same for import_type as import.
It may just work with your updates in edoc. Add a testcase to the eep48_SUITE that checks that an imported type behaves the same as a remote type. |
EEP: erlang/eep#51