Remove unnecessary regex lib used by ycf #7823
Conversation
rickard-green
added
team:VM
CT Test Results 3 files 140 suites 46m 18s ⏱️ Results for commit 267b089. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
| { | ||
| return ('0' <= c && c <= '9'); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is there a reason for not using the libc functions isspace(), isalnum(), isalpha() and isdigit()? If I read the documentation correctly they have been around since C89 and as a bonus are locale aware.
There was a problem hiding this comment.
Yes, the reason is that they're locale-aware. Friends don't let friends use locale.
…rm_tiny-regex-c_lib/25/OTP-18830 * rickard/rm_tiny-regex-c_lib/24/OTP-18830: [erts] Remove unnecessary regex lib
…rm_tiny-regex-c_lib/OTP-18830 * rickard/rm_tiny-regex-c_lib/25/OTP-18830: [erts] Remove unnecessary regex lib
rickard-green
force-pushed
the
rickard/rm_tiny-regex-c_lib/OTP-18830
branch
from
6bc3ba2
to
267b089
Compare
No description provided.