Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public_key: Correct match_name function for dnsNames #8508

Conversation

IngelaAndin
Copy link
Contributor

Closes #8482

@IngelaAndin IngelaAndin requested review from dgud and u3s May 24, 2024 08:58
@IngelaAndin IngelaAndin self-assigned this May 24, 2024
@IngelaAndin IngelaAndin added team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI labels May 24, 2024
Copy link
Contributor

github-actions bot commented May 24, 2024

CT Test Results

  2 files   17 suites   5m 20s ⏱️
283 tests 281 ✅ 2 💤 0 ❌
299 runs  297 ✅ 2 💤 0 ❌

Results for commit 40857b0.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkits_SUITE fails ... ?

@IngelaAndin IngelaAndin force-pushed the ingela/public_key/match_dnsName/GH-8482/OTP-19100 branch from 74f8310 to 40857b0 Compare May 24, 2024 10:48
@IngelaAndin
Copy link
Contributor Author

@u3s yes I noticed, problem was a little more intricate then it first seemed. Should be fixed now!

@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label May 24, 2024
@IngelaAndin IngelaAndin requested a review from u3s May 24, 2024 11:55
@IngelaAndin IngelaAndin merged commit 12c6b0a into erlang:maint May 27, 2024
16 checks passed
@IngelaAndin
Copy link
Contributor Author

Planned for OTP 26.2.5.1 and OTP-27.0.1, next upcoming patches. Summer period is a little slower due to vacation period. Can not give you any date, but will be announced at the https://erlangforums.com/

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants