[backed down] OTP 18.2 HiPE fix for FreeBSD 10.2-STABLE #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* emulator/sys/common/erl_mmap.h: MAP_NORESERVE is undefined in FreeBSD 10.x and later. This is to enable 64bit HiPE experimentally on FreeBSD. Note that on FreeBSD MAP_NORESERVE was "never implemented" even before 11.x (and the flag does not exist in /usr/src/sys/vm/mmap.c of 10.2-STABLE r291856 either), and HiPE was working on OTP 18.1.5, so mandating MAP_NORESERVE on FreeBSD might not be needed. See the following message on how MAP_NORESERVE was treated on FreeBSD: <http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150202/122958.html>
* erts/emulator/hipe/hipe_x86_signal.c: add FreeBSD sigaction code, based on the Darwin (OS X) code
|
See also #893, especially the comments |
|
As @sverker pointed out for jj1bdx@b02ce94, I probably mixed up patches for 18.2 and 19. jj1bdx@b02ce94 seems to be irrelevant. I will close and back out this pull request and issue another one. |
jj1bdx
changed the title
|
See #926 for the new PR. |
|
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: #926 is the follow-up for this PR. This PR is obsolete.
This pull request includes an experimental fix of running HiPE on FreeBSD.
Two fixes are included: