Write rebar3.crashdump on errors #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do prefer the DEBUG=1 for contextual output, though. |
|
this does not change the behavior of DEBUG=1 or the error message, it simply adds a rebar3.crashdump to the cases where a DEBUG=1 message was formerly printed. |
| @@ -265,7 +265,8 @@ handle_error({error, rebar_abort}) -> | |||
| handle_error({error, {Module, Reason}}) -> | |||
| case code:which(Module) of | |||
| non_existing -> | |||
| ?ERROR("Uncaught error in rebar_core. Run with DEBUG=1 to see stacktrace", []), | |||
| file:write_file("rebar3.crashdump", io_lib:fwrite("~p: ~p~n~p~n~n", [Module, Reason, erlang:get_stacktrace()])), | |||
| ?ERROR("Uncaught error in rebar_core. Run with DEBUG=1 to see stacktrace rebar3.crashdump", []), | |||
There was a problem hiding this comment.
This error line is not an actual sentence?
|
WOuld that also drop files over the filesystem when run in API mode? I don't really like that. |
|
Updated it so the sentences are nicer and it will recognize api mode and not write a crash file |
|
+1 on this. Does not sound like a bad idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.