Fix bugs/race conditions in shell #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following suggestions from @psyeugenic, this code terminates and waits for the termination of the port handling IO before booting our own, which should get rid of annoying warnings. We also allow for the failure to shutdown the user worker under kernel_sup, since it is likely not there anymore in many scenarios, preventing crashes.
|
👍 |
|
I used this rebar in the same way that I have previously [that got the bad behavior in #1028] on a project that was having this issue about every 1 in 10 tries. After 100 shell runs I did not receive the error. It's not conclusive because the error was not consistently reproducible, but given a large number of attempts it looks to be working as intended. I did not encounter any other issues with rebar while testing this. |
tsloughter
added a commit
that referenced
this pull request
Mar 19, 2016
Fix bugs/race conditions in shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following suggestions from @psyeugenic, this code terminates and waits
for the termination of the port handling IO before booting our own,
which should get rid of annoying warnings.
We also allow for the failure to shutdown the user worker under
kernel_sup, since it is likely not there anymore in many scenarios,
preventing crashes.
Tested on linux and OSX under escript and local install, with and without TERM=dumb. Windows testing still required.
Should fix #1028