Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract dist config handling, support {dist_node, ...} #1132

Merged
merged 2 commits into from
Apr 1, 2016

Conversation

ferd
Copy link
Collaborator

@ferd ferd commented Mar 21, 2016

This commit moves the handling of distribution config and starting out
of rebar_prv_shell and into rebar_dist_utils. The module is able to
handle standard config options and boot a distributed node mode. This
could be used in plugins (once it is exposed) and other providers like
CT.

Configuration is also expanded so that options like:

{dist_node, [{sname, atom()}, {name, atom()}, {setcookie, term()}]}

can be used and will be handled as a default. The config handler
supports similar terms from the command line being parsed in if the
calling provider supports them.

A test suite is added for configuration handling.


This is open for comments in how to handle the options or how to name them.

This commit moves the handling of distribution config and starting out
of rebar_prv_shell and into rebar_dist_utils. The module is able to
handle standard config options and boot a distributed node mode. This
could be used in plugins (once it is exposed) and other providers like
CT.

Configuration is also expanded so that options like:

    {dist, [{sname, atom()}, {name, atom()}, {setcookie, term()}]}

can be used and will be handled as a default. The config handler
supports similar terms from the command line being parsed in if the
calling provider supports them.

A test suite is added for configuration handling.
@ferd ferd changed the title WIP/RFC: Extract dist config handling, support {dist, ...} RFC: Extract dist config handling, support {dist, ...} Apr 1, 2016
@tsloughter
Copy link
Collaborator

+1 Very nice. Maybe a more clear name for the config option would be dist_node?

@ferd
Copy link
Collaborator Author

ferd commented Apr 1, 2016

Yeah I'm okay with that rename. Will do it right away.

@ferd ferd changed the title RFC: Extract dist config handling, support {dist, ...} Extract dist config handling, support {dist_node, ...} Apr 1, 2016
@ferd
Copy link
Collaborator Author

ferd commented Apr 1, 2016

Renamed.

@ferd ferd merged commit c5ee8e2 into erlang:master Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants