Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supported dist_node in ct and eunit #1152

Merged
merged 2 commits into from
Apr 7, 2016

Conversation

soranoba
Copy link
Contributor

@soranoba soranoba commented Apr 7, 2016

If we try to use the ct_slave in rebar3 ct, net_kernel:start is required each time.
In rebar2 it was not that necessary.
I want that the setting of dist_node is applied to ct and eunit.

@ferd
Copy link
Collaborator

ferd commented Apr 7, 2016

You need to add the sname, name and setcookie options into the provider list of accepted arguments in init (see https://github.com/soranoba/rebar3/blob/feature/test-distnode/src/rebar_prv_common_test.erl#L620) otherwise I don't think this will work super well.

@soranoba
Copy link
Contributor Author

soranoba commented Apr 7, 2016

Is this OK?

@ferd
Copy link
Collaborator

ferd commented Apr 7, 2016

Yeah that's good, +1 from me. Unless @talentdeficit has any comments on it, I'll merge this sooner than later.

@talentdeficit
Copy link
Contributor

+1 here

@ferd ferd merged commit 0ad1113 into erlang:master Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants