Fix path command to consider {deps_dir, "deps"} in rebar.config #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| lib_dir(State) -> io_lib:format("~s/lib", [rebar_dir:base_dir(State)]). | ||
| lib_dir(State) -> io_lib:format("~s/~s", [rebar_dir:base_dir(State), | ||
| rebar_state:get(State, deps_dir, | ||
| ?DEFAULT_DEPS_DIR)]). |
There was a problem hiding this comment.
Rather than using this format, consider calling rebar_dir:deps_dir/1 for all of this patch. It seems that using rebar_dir:base_dir/1 was just an oversight.
|
I'm okay with the objective and patching of this PR, but believe the implementation should reuse |
|
Good point. Fixed. Thanks. |
|
You only changed it for 1/4 of the lines there. The same comment applies to all 3 others. Sorry I wasn't clear enough. |
|
Fixed, common tests are ok locally, no idea why failed here. |
|
Some test that apparently fails from time to time. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.