Bugfix for upgrading deps of umbrella apps #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the operation for an unlock takes place in the config of a umbrella application, the `unlock' provider does not see the dependency in the `deps' value of the config (since it only includes the deps at the root of the project) and ignores these.
ferd
changed the title
|
I don't think you need the |
|
That was my initial assumption, but It doesn't appear so, at least half the tests were failing where data was in |
The previous iteration of the patch worked somewhat by accident. After digging in and figuring out why the two dep sources are the way they are, the patch is now properly working with a well-documented explanatiion inline.
|
@tsloughter last commit explains the format and solution now that I get it. |
|
Cool, good docs, i think this is good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the operation for an unlock takes place in the config of a umbrella
application, the
unlockprovider does not see the dependency in thedepsvalue of the config (since it only includes the deps at the rootof the project) and ignores these.
Ref: #1193