bug when reread_config running on OTP 17 #2093
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good. OTP-17 won't officially be supported on the next release anymore (since OTP-22 is out), but I'll merge this anyway since it's correct and does not hurt to keep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in latest rebar3 when running rebar3 ct on OTP 17.5. The ct process would be terminated automatically without any error printed.
After digging it turned out the configuration file, either defined in rebar.config or passed by parameter --sys_config is not loaded properly when running rebar3 ct.
From the release here: https://github.com/erlang/otp/releases/tag/OTP-17.0 we can see {persistent, boolean()} is supported from otp 17, so when reread_config, rebar3 should call application:set_env(App, Key, Val, [{persistent, true}]) for OTP releases > 17.
After the modification, locally rebar3 ct now works properly.