{xref_ignores} now properly works on module, #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction calls.
Summary: Before, the xref_ignores would properly ignores function calls on specified modules. That is,
even though {xref_ignores, [ModName,...]} would be in rebar3.config, those unassigned function calls
to and from the ModName module would be displayed.
This was due to a mismatch between the format of the ignore (a module name), and the format of the
warning ({MFA, MFA} or MFA) emmited by xref.
|
Could you add tests to https://github.com/erlang/rebar3/blob/master/test/rebar_xref_SUITE.erl ? |
…unction calls.
Summary: Before, the xref_ignores would properly ignores function calls on specified modules. That is,
even though {xref_ignores, [ModName,...]} would be in rebar3.config, those unassigned function calls
to and from the ModName module would be displayed.
This was due to a mismatch between the format of the ignore (a module name), and the format of the
warning ({MFA, MFA} or MFA) emmited by xref.
|
Tests added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by correctly removing warning about functions.
Summary: Before, the xref_ignores would not properly ignores functions warning on specified modules. That is,
for instance, even though {xref_ignores, [ModName,...]} would be in rebar3.config, unassigned function calls
to and from the ModName module would be displayed.
This was due to a mismatch between the format of the ignore (a module name), and the format of the
warning ({MFA, MFA} or MFA) emitted by xref.