Fix optimistic registry update of plugins being upgraded #2568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starbelly
approved these changes
May 26, 2021
This apparently never worked properly, the call being made swapped arguments order, but kept the type correct enough that no type warning would be raised. This isn't a problem though, because before this optimization, people were already used to calling 'rebar3 update' before upgrading a plugin. This being fixed makes that call optional now.
ferd
force-pushed
the
fix-optimistic-plugin-cache-update
branch
from
607f910
to
5e0d71d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This apparently never worked properly, the call being made swapped
arguments order, but kept the type correct enough that no type warning
would be raised.
This isn't a problem though, because before this optimization, people
were already used to calling 'rebar3 update' before upgrading a plugin.
This being fixed makes that call optional now.