Prevent crashes on recursive src_dir definitions in deps #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some rare cases (see erlang#2581 for a sample interplay between plugins and recursive dep definitions with apps) there can be some interplay where a dependency declares recursive directories but the lookup for app files does not acknowledges these and causes problems. This patch simply ignores such cases by stripping options; this should have no backward compatibility impact since the value was just ignored before anyway, but will prevent crashes in hard-to-reproduce cases.
AnufrievDE
reviewed
Jun 21, 2021
Co-authored-by: Denis Anufriev <anufriev.denis.e@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases (see #2581 for a sample interplay between plugins
and recursive dep definitions with apps) there can be some interplay where
a dependency declares recursive directories but the lookup for app files does
not acknowledge these and causes problems.
This patch simply ignores such cases by stripping options; this should
have no backward compatibility impact since the value was just ignored
before anyway, but will prevent crashes in hard-to-reproduce cases.
Possibly fixes #2581 but I haven't been able to reproduce this in tests
since it seems to require a very peculiar setup to trigger.